tabstrip: Use a PaintRecorder to access the Canvas for painting.

ui/compositor/compositing_recorder.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/compositing_recorder.h"
 
 #include "ui/compositor/paint_context.h"
 #include "ui/gfx/canvas.h"
 
 namespace ui {
 
-CompositingRecorder::CompositingRecorder(const PaintContext& context,
-                                         float opacity)
-    : canvas_(context.canvas()) {
-  canvas_->SaveLayerAlpha(0xff * opacity);
+CompositingRecorder::CompositingRecorder(const PaintContext& context, int alpha)
+    : canvas_(context.canvas()), saved_(alpha < 255) {
+  DCHECK_GE(alpha, 0);
+  DCHECK_LE(alpha, 255);
+  if (saved_)
+    canvas_->SaveLayerAlpha(alpha);

[Peter Kasting, 2015/04/07 21:32:39]

Because SaveLayerAlpha() takes a uint8, I think |alpha| should also be a uint8
(well, probably a uint8_t).  This eliminates the need to do DCHECKs as well.

[danakj, 2015/04/07 21:36:26]

I did this at first (which is why the extra git cl format changes). But the
style guide pretty clearly says to use int not unsigned, and use DCHECKs for
bounds checking instead:

"Do not use unsigned types to mean "this value should never be < 0". For that,
use assertions or run-time checks (as appropriate)."

That feels like it probably applies to "should never be > 255" just the same?
And the existing code is all ints.

WDYT?

[Peter Kasting, 2015/04/07 21:45:59]

I would prefer to be consistent with the existing API there.  If someone later
wants to change all levels of the API to use int at once they can.

Even in that case, I actually think this is a case where use of uint8_t is
arguably correct.  It's not just "can't be less than zero", it's a very specific
range of values that corresponds exactly to a particular type.  The specific
sized-ness of the type is relevant.

 }
 
 CompositingRecorder::~CompositingRecorder() {
-  canvas_->Restore();
+  if (saved_)
+    canvas_->Restore();
 }
 
 }  // namespace ui