Chromium Code Reviews

Issue 1062283002: Use C++11 range-based loop for core/layout (Closed)

Created:
5 years, 8 months ago by rwlbuis
Modified:
5 years, 8 months ago
Reviewers:
pdr., pilgrim_google
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, Stephen Chennney, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use C++11 range-based loop for core/layout Use C++11 range-based loop for core/layout for improved readability. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193369

Patch Set 1 #

Patch Set 2 : Some cleanups #

Total comments: 2

Patch Set 3 : Fix it naming #

Unified diffs Side-by-side diffs Stats (+77 lines, -120 lines)
M Source/core/layout/ImageQualityController.cpp View 1 chunk +3 lines, -3 lines 0 comments
M Source/core/layout/LayoutBlock.cpp View 12 chunks +39 lines, -66 lines 0 comments
M Source/core/layout/LayoutBlockFlowLine.cpp View 3 chunks +8 lines, -12 lines 0 comments
M Source/core/layout/LayoutFlowThread.cpp View 2 chunks +3 lines, -6 lines 0 comments
M Source/core/layout/LayoutTableSection.cpp View 1 chunk +2 lines, -3 lines 0 comments
M Source/core/layout/SubtreeLayoutScope.cpp View 1 chunk +2 lines, -2 lines 0 comments
M Source/core/layout/TextAutosizer.cpp View 2 chunks +4 lines, -5 lines 0 comments
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 chunk +2 lines, -2 lines 0 comments
M Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 3 chunks +7 lines, -11 lines 0 comments
M Source/core/layout/svg/LayoutSVGResourceGradient.cpp View 1 chunk +2 lines, -3 lines 0 comments
M Source/core/layout/svg/SVGResourcesCycleSolver.cpp View 2 chunks +5 lines, -7 lines 0 comments

Messages

Total messages: 11 (4 generated)
rwlbuis
PTAL :) I removed some of the const_iterator changes from zhou's patch.
5 years, 8 months ago (2015-04-07 22:50:39 UTC) #2
pdr.
@pilgrim, would you be up for reviewing this change? https://codereview.chromium.org/1062283002/diff/20001/Source/core/layout/ImageQualityController.cpp File Source/core/layout/ImageQualityController.cpp (right): https://codereview.chromium.org/1062283002/diff/20001/Source/core/layout/ImageQualityController.cpp#newcode134 Source/core/layout/ImageQualityController.cpp:134: ...
5 years, 8 months ago (2015-04-08 03:03:28 UTC) #4
pilgrim_google
On 2015/04/08 at 03:03:28, pdr wrote: > @pilgrim, would you be up for reviewing this ...
5 years, 8 months ago (2015-04-08 13:12:53 UTC) #5
rwlbuis
On 2015/04/08 13:12:53, pilgrim_google wrote: > On 2015/04/08 at 03:03:28, pdr wrote: > > @pilgrim, ...
5 years, 8 months ago (2015-04-08 13:48:04 UTC) #6
pdr.
lgtm
5 years, 8 months ago (2015-04-08 15:38:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062283002/40001
5 years, 8 months ago (2015-04-08 15:38:25 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 16:58:20 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193369

Powered by Google App Engine