chrome power profiler chrome side changes

content/browser/browser_process_sub_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_process_sub_thread.h"
 
 #include "base/debug/leak_tracker.h"
 #include "base/threading/thread_restrictions.h"
 #include "build/build_config.h"
 #include "content/browser/browser_child_process_host_impl.h"
 #include "content/browser/notification_service_impl.h"
+#include "content/browser/power_profiler/power_profiler_service.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request.h"
 
 #if defined(OS_WIN)
 #include "base/win/scoped_com_initializer.h"
 #endif
 
 namespace content {
 
 BrowserProcessSubThread::BrowserProcessSubThread(BrowserThread::ID identifier)
@@ skipping 13 matching lines @@
 
   BrowserThreadImpl::Init();
 
   if (BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     // Though this thread is called the "IO" thread, it actually just routes
     // messages around; it shouldn't be allowed to perform any blocking disk
     // I/O.
     base::ThreadRestrictions::SetIOAllowed(false);
     base::ThreadRestrictions::DisallowWaiting();
   }
+  if (BrowserThread::CurrentlyOn(BrowserThread::POWER_PROFILER)) {
+    power_profiler_service_.reset(new PowerProfilerService);

[pfeldman, 2014/01/09 11:38:58]

You should either use lazy_init, singleton or BrowserContextKeyedService
depending on how many instances you want to have, deletion pattern and
threading. Not manual initialization like this.

+  }
 }
 
 void BrowserProcessSubThread::CleanUp() {
   if (BrowserThread::CurrentlyOn(BrowserThread::IO))
     IOThreadPreCleanUp();
 
+  if (BrowserThread::CurrentlyOn(BrowserThread::POWER_PROFILER))
+    PowerProfilerThreadPreCleanUp();
+
   BrowserThreadImpl::CleanUp();
 
   notification_service_.reset();
 
 #if defined(OS_WIN)
   com_initializer_.reset();
 #endif
 }
 
 void BrowserProcessSubThread::IOThreadPreCleanUp() {
   // Kill all things that might be holding onto
   // net::URLRequest/net::URLRequestContexts.
 
   // Destroy all URLRequests started by URLFetchers.
   net::URLFetcher::CancelAll();
 
 #if !defined(OS_IOS)
   // If any child processes are still running, terminate them and
   // and delete the BrowserChildProcessHost instances to release whatever
   // IO thread only resources they are referencing.
   BrowserChildProcessHostImpl::TerminateAll();
 #endif  // !defined(OS_IOS)
 }
 
+void BrowserProcessSubThread::PowerProfilerThreadPreCleanUp() {
+  power_profiler_service_.reset();
+}
+
 }  // namespace content