Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1062223002: Cleanup: Remove basictypes.h includes from seccomp-bpf-helpers. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, mdempsky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove basictypes.h includes from seccomp-bpf-helpers. Tested on Linux with the following command lines: $ rm -rf out/ $ ./build/gyp_chromium $ ninja -C out/Debug sandbox_linux_unittests $ out/Debug/sandbox_linux_unittests BUG=138542 TEST=see above R=jln@chromium.org,mdempsky@chromium.org Committed: https://crrev.com/de79bd9e93c161fe98a97499a6f06b7f2f0823d8 Cr-Commit-Position: refs/heads/master@{#324378}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc View 1 chunk +0 lines, -1 line 2 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 2 chunks +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
5 years, 8 months ago (2015-04-07 18:23:30 UTC) #1
tfarina
Julien or Matthew, ping??
5 years, 8 months ago (2015-04-09 02:01:24 UTC) #2
mdempsky
lgtm https://codereview.chromium.org/1062223002/diff/1/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc File sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc (right): https://codereview.chromium.org/1062223002/diff/1/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc#newcode10 sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:10: #include <unistd.h> Add #include <stdint.h>.
5 years, 8 months ago (2015-04-09 02:04:54 UTC) #4
tfarina
https://codereview.chromium.org/1062223002/diff/1/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc File sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc (right): https://codereview.chromium.org/1062223002/diff/1/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc#newcode10 sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:10: #include <unistd.h> On 2015/04/09 02:04:54, mdempsky wrote: > Add ...
5 years, 8 months ago (2015-04-09 02:56:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062223002/1
5 years, 8 months ago (2015-04-09 02:56:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 04:52:24 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 04:53:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de79bd9e93c161fe98a97499a6f06b7f2f0823d8
Cr-Commit-Position: refs/heads/master@{#324378}

Powered by Google App Engine
This is Rietveld 408576698