Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1062203002: Get rid of unnecessary speech logs from ChromeVox (Closed)

Created:
5 years, 8 months ago by dmazzoni
Modified:
5 years, 8 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_content_script_on_bkgnd_page
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of unnecessary speech logs from ChromeVox The start and end callback logs were from a long time ago when those were new and not as stable. Get rid of them now. BUG=none Committed: https://crrev.com/f449e0708bd8587372e1998ac4800ed05dff614f Cr-Commit-Position: refs/heads/master@{#324284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/console_tts.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
5 years, 8 months ago (2015-04-07 17:59:18 UTC) #2
David Tseng
lgtm
5 years, 8 months ago (2015-04-08 16:31:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062203002/1
5 years, 8 months ago (2015-04-08 19:03:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 21:08:25 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 21:09:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f449e0708bd8587372e1998ac4800ed05dff614f
Cr-Commit-Position: refs/heads/master@{#324284}

Powered by Google App Engine
This is Rietveld 408576698