track global accesses to constant types

src/hydrogen.cc

Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 03bd971a825ce7ceee500e4122265eb8fa70ed5b..61a4c0ddd04d2e1b703d6dfdd60ad2ef6fa791d6 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5396,8 +5396,10 @@ void HOptimizedGraphBuilder::VisitVariableProxy(VariableProxy* expr) {
 
       if (type == kUseCell) {
         Handle<PropertyCell> cell = it.GetPropertyCell();
-        PropertyCell::AddDependentCompilationInfo(cell, top_info());
-        if (it.property_details().cell_type() == PropertyCellType::kConstant) {
+        auto cell_type = it.property_details().cell_type();
+        if (cell_type == PropertyCellType::kConstant ||
+            cell_type == PropertyCellType::kUndefined) {
+          PropertyCell::AddDependentCompilationInfo(cell, top_info());
           Handle<Object> constant_object(cell->value(), isolate());
           if (constant_object->IsConsString()) {
             constant_object =
@@ -5406,9 +5408,41 @@ void HOptimizedGraphBuilder::VisitVariableProxy(VariableProxy* expr) {
           HConstant* constant = New<HConstant>(constant_object);
           return ast_context()->ReturnInstruction(constant, expr->id());
         } else {
+          auto access = HObjectAccess::ForPropertyCellValue();
+          UniqueSet<Map>* field_maps = nullptr;
+          if (cell_type == PropertyCellType::kConstantType) {
+            switch (cell->GetConstantType()) {
+              case PropertyCellConstantType::kSmi:
+                access = access.WithRepresentation(Representation::Smi());
+                break;
+              case PropertyCellConstantType::kStableMap: {
+                // Check that the map really is stable. The heap object could
+                // have mutated without the cell updating state.
+                Handle<Map> map(HeapObject::cast(cell->value())->map());
+                if (map->is_stable()) {
+                  access =
+                      access.WithRepresentation(Representation::HeapObject());
+                  field_maps = new (zone())
+                      UniqueSet<Map>(Unique<Map>::CreateImmovable(map), zone());
+                } else {
+                  // TODO(dcarney): bailout here or deopt?
+                  auto dictionary = handle(global->property_dictionary());
+                  cell = PropertyCell::InvalidateEntry(dictionary,
+                                                       it.dictionary_entry());
+                }
+                break;
+              }
+            }
+          }
+          PropertyCell::AddDependentCompilationInfo(cell, top_info());
           HConstant* cell_constant = Add<HConstant>(cell);
-          HLoadNamedField* instr = New<HLoadNamedField>(
-              cell_constant, nullptr, HObjectAccess::ForPropertyCellValue());
+          HLoadNamedField* instr;
+          if (field_maps == nullptr) {
+            instr = New<HLoadNamedField>(cell_constant, nullptr, access);
+          } else {
+            instr = New<HLoadNamedField>(cell_constant, nullptr, access,
+                                         field_maps, HType::HeapObject());
+          }
           instr->ClearDependsOnFlag(kInobjectFields);
           instr->SetDependsOnFlag(kGlobalVars);
           return ast_context()->ReturnInstruction(instr, expr->id());
@@ -6564,7 +6598,9 @@ void HOptimizedGraphBuilder::HandleGlobalVariableAssignment(
   if (type == kUseCell) {
     Handle<PropertyCell> cell = it.GetPropertyCell();
     PropertyCell::AddDependentCompilationInfo(cell, top_info());
-    if (it.property_details().cell_type() == PropertyCellType::kConstant) {
+    auto cell_type = it.property_details().cell_type();
+    if (cell_type == PropertyCellType::kConstant ||
+        cell_type == PropertyCellType::kUndefined) {
       Handle<Object> constant(cell->value(), isolate());
       if (value->IsConstant()) {
         HConstant* c_value = HConstant::cast(value);
@@ -6588,8 +6624,35 @@ void HOptimizedGraphBuilder::HandleGlobalVariableAssignment(
       }
     }
     HConstant* cell_constant = Add<HConstant>(cell);
-    HInstruction* instr = Add<HStoreNamedField>(
-        cell_constant, HObjectAccess::ForPropertyCellValue(), value);
+    auto access = HObjectAccess::ForPropertyCellValue();
+    StoreFieldOrKeyedMode store_mode = INITIALIZING_STORE;
+    if (cell_type == PropertyCellType::kConstantType) {
+      // store_mode = STORE_TO_INITIALIZED_ENTRY;
+      switch (cell->GetConstantType()) {
+        case PropertyCellConstantType::kSmi:
+          Add<HCheckSmi>(value);

[dcarney, 2015/04/21 07:20:07]

same questions as in the code stub

+          access = access.WithRepresentation(Representation::Smi());
+          break;
+        case PropertyCellConstantType::kStableMap: {
+          // Check that the map really is stable. The heap object could have
+          // mutated without the cell updating state.
+          Handle<Map> map(HeapObject::cast(cell->value())->map());
+          if (map->is_stable()) {
+            Add<HCheckHeapObject>(value);
+            value = Add<HCheckMaps>(value, map);
+            access = access.WithRepresentation(Representation::HeapObject());
+          } else {
+            // TODO(dcarney): bailout here or deopt?

[dcarney, 2015/04/21 07:20:07]

what to do here and above?

+            auto dictionary = handle(global->property_dictionary());
+            cell = PropertyCell::InvalidateEntry(dictionary,
+                                                 it.dictionary_entry());
+          }
+          break;
+        }
+      }
+    }
+    HInstruction* instr =
+        Add<HStoreNamedField>(cell_constant, access, value, store_mode);
     instr->ClearChangesFlag(kInobjectFields);
     instr->SetChangesFlag(kGlobalVars);
     if (instr->HasObservableSideEffects()) {