chrome/test/data/prerender/plugin_delay_load.html - Issue 1062163004: Plugins: Move Prerender tests to PPAPI and some refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/prerender/plugin_delay_load.html

Issue 1062163004: Plugins: Move Prerender tests to PPAPI and some refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/test/data/prerender/plugin_never_load.html » ('j') | chrome/test/data/prerender/plugin_never_load.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/prerender/plugin_delay_load.html

diff --git a/chrome/test/data/prerender/plugin_delay_load.html b/chrome/test/data/prerender/plugin_delay_load.html

index cc18dc3303319f9ad45f62f159a4e2447b7ba105..a8606a99224da29945e437d1526a13defece730a 100644

--- a/chrome/test/data/prerender/plugin_delay_load.html

+++ b/chrome/test/data/prerender/plugin_delay_load.html

@@ -1,7 +1,10 @@

<html>

-<!--

+<!--

This test checks to make sure plugins aren't loaded when a page is prerendered,

but are loaded once the page is displayed.

+This test relies on the Pepper plugin (but not the placeholder) implementing

+a the postMessage() function on the plugin object.

raymes 2015/04/15 06:44:18 nit: the postMessage() function

tommycli 2015/04/15 18:23:18 Done.

-->

<head>

<title>Prerender Plugin Delay Loading</title>

@@ -12,18 +15,18 @@ function DidPrerenderPass() {

// |plugin| should be the blocked plugin placeholder, rather than the

// test plugin.

var plugin = window.document['plugin'];

- return plugin.getURL == undefined;

+ return plugin.postMessage == undefined;

}

// Make sure plugin loads once the page is displayed.

function DidDisplayPass() {

var plugin = window.document['plugin'];

- return plugin.getURL != undefined;

+ return plugin.postMessage != undefined;

}

</script>

</head>

<body>

-<embed name="plugin" type="application/x-webkit-test-netscape"></embed>

+<embed name="plugin" type="application/x-ppapi-tests"></embed>

</body>

</html>