Plugins: Move Prerender tests to PPAPI and some refactoring.

chrome/browser/prerender/prerender_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <deque>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 66 matching lines @@
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
+#include "content/public/test/ppapi_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/manifest_handlers/mime_types_handler.h"
 #include "extensions/common/switches.h"
 #include "extensions/test/result_catcher.h"
 #include "net/base/escape.h"
 #include "net/cert/x509_certificate.h"
 #include "net/dns/mock_host_resolver.h"
@@ skipping 968 matching lines @@
 };
 
 base::FilePath GetTestPath(const std::string& file_name) {
   return ui_test_utils::GetTestFilePath(
       base::FilePath(FILE_PATH_LITERAL("prerender")),
       base::FilePath().AppendASCII(file_name));
 }
 
 }  // namespace
 
-// Many of these tests are flaky. See http://crbug.com/249179
 class PrerenderBrowserTest : virtual public InProcessBrowserTest {
  public:
   PrerenderBrowserTest()
       : autostart_test_server_(true),
         prerender_contents_factory_(NULL),
 #if defined(FULL_SAFE_BROWSING)
         safe_browsing_factory_(new TestSafeBrowsingServiceFactory()),
 #endif
         call_javascript_(true),
         check_load_events_(true),
@@ skipping 17 matching lines @@
 
   void TearDownInProcessBrowserTestFixture() override {
 #if defined(FULL_SAFE_BROWSING)
     SafeBrowsingService::RegisterFactory(NULL);
 #endif
   }
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     command_line->AppendSwitchASCII(switches::kPrerenderMode,
                                     switches::kPrerenderModeSwitchValueEnabled);
-#if defined(OS_MACOSX)
-    // The plugins directory isn't read by default on the Mac, so it needs to be
-    // explicitly registered.
-    base::FilePath app_dir;
-    PathService::Get(chrome::DIR_APP, &app_dir);
-    command_line->AppendSwitchPath(
-        switches::kExtraPluginDir,
-        app_dir.Append(FILE_PATH_LITERAL("plugins")));
-#endif
-    command_line->AppendSwitch(switches::kAlwaysAuthorizePlugins);
-    command_line->AppendSwitch(switches::kEnableNpapi);
+    ASSERT_TRUE(ppapi::RegisterTestPlugin(command_line));
   }
 
   void SetPreference(NetworkPredictionOptions value) {
     browser()->profile()->GetPrefs()->SetInteger(
         prefs::kNetworkPredictionOptions, value);
   }
 
   // Verifies whether ShouldDisableLocalPredictorDueToPreferencesAndNetwork
   // produces the desired output.
   void TestShouldDisableLocalPredictorPreferenceNetworkMatrix(
@@ skipping 904 matching lines @@
 // Checks that the prerendering of a page is canceled correctly when a
 // Javascript alert is called.
 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderAlertAfterOnload) {
   PrerenderTestURL("files/prerender/prerender_alert_after_onload.html",
                    FINAL_STATUS_JAVASCRIPT_ALERT,
                    1);
 }
 
 // Checks that plugins are not loaded while a page is being preloaded, but
 // are loaded when the page is displayed.
-#if defined(USE_AURA) && !defined(OS_WIN)
-// http://crbug.com/103496
-#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
-#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
-#elif defined(OS_MACOSX)
-// http://crbug.com/100514
-#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
-#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
-#elif defined(OS_WIN) && defined(ARCH_CPU_X86_64)
-// TODO(jschuh): Failing plugin tests. crbug.com/244653
-#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
-#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
-#elif defined(OS_LINUX)
-// http://crbug.com/306715
-#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
-#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
-#else
-#define MAYBE_PrerenderDelayLoadPlugin PrerenderDelayLoadPlugin
-#define MAYBE_PrerenderPluginPowerSaver PrerenderPluginPowerSaver
-#endif
-// http://crbug.com/306715
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, MAYBE_PrerenderDelayLoadPlugin) {
-  PrerenderTestURL("files/prerender/plugin_delay_load.html",
-                   FINAL_STATUS_USED,
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderDelayLoadPlugin) {
+  PrerenderTestURL("files/prerender/plugin_delay_load.html", FINAL_STATUS_USED,
                    1);
   NavigateToDestURL();
 }
 
-// For enabled Plugin Power Saver, checks that plugins are not loaded while
+// For Content Setting DETECT, checks that plugins are not loaded while
 // a page is being preloaded, but are loaded when the page is displayed.
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, MAYBE_PrerenderPluginPowerSaver) {
-  // Enable click-to-play.
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderContentSettingDetect) {
   HostContentSettingsMap* content_settings_map =
       current_browser()->profile()->GetHostContentSettingsMap();
   content_settings_map->SetDefaultContentSetting(
       CONTENT_SETTINGS_TYPE_PLUGINS, CONTENT_SETTING_DETECT_IMPORTANT_CONTENT);
 
-  PrerenderTestURL("files/prerender/prerender_plugin_power_saver.html",
-                   FINAL_STATUS_USED, 1);
+  PrerenderTestURL("files/prerender/plugin_delay_load.html", FINAL_STATUS_USED,
+                   1);
   NavigateToDestURL();
 }
 
+// For Content Setting BLOCK, checks that plugins are never loaded.
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderContentSettingBlock) {
+  HostContentSettingsMap* content_settings_map =
+      current_browser()->profile()->GetHostContentSettingsMap();
+  content_settings_map->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS,
+                                                 CONTENT_SETTING_BLOCK);
+
+  PrerenderTestURL("files/prerender/plugin_never_load.html", FINAL_STATUS_USED,
+                   1);
+  NavigateToDestURL();
+}
+
 // Checks that we don't load a NaCl plugin when NaCl is disabled.
 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderNaClPluginDisabled) {
   PrerenderTestURL("files/prerender/prerender_plugin_nacl_disabled.html",
                    FINAL_STATUS_USED,
                    1);
   NavigateToDestURL();
 
 
   // Run this check again.  When we try to load aa ppapi plugin, the
   // "loadstart" event is asynchronously posted to a message loop.
@@ skipping 2052 matching lines @@
   TestShouldDisableLocalPredictorPreferenceNetworkMatrix(
       false /*preference_wifi_network_wifi*/,
       false /*preference_wifi_network_4g*/,
       false /*preference_always_network_wifi*/,
       false /*preference_always_network_4g*/,
       false /*preference_never_network_wifi*/,
       false /*preference_never_network_4g*/);
 }
 
 }  // namespace prerender