content/public/test/OWNERS - Issue 1062163004: Plugins: Move Prerender tests to PPAPI and some refactoring.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/test/OWNERS

Issue 1062163004: Plugins: Move Prerender tests to PPAPI and some refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 jcivelli@chromium.org	1 jcivelli@chromium.org

2 phajdan.jr@chromium.org	2 phajdan.jr@chromium.org

3 sky@chromium.org	3 sky@chromium.org

4	4

5 # For WebRTC files.	5 # For WebRTC files.

6 tommi@chromium.org	6 tommi@chromium.org

	7

	8 per-file ppapi*=bbudge@chromium.org
	Paweł Hajdan Jr. 2015/04/16 21:36:18 Why are these entries needed? Why are these entries needed? tommycli 2015/04/16 22:18:51 Done. I realized i could move the whole thing back Show quoted text On 2015/04/16 21:36:18, Paweł Hajdan Jr. wrote: > Why are these entries needed? Done. I realized i could move the whole thing back to ppapi, so these entries are gone now. tommycli 2015/04/16 23:35:42 Actually, I wasn't able to move it back. I added t Show quoted text On 2015/04/16 22:18:51, tommycli wrote: > On 2015/04/16 21:36:18, Paweł Hajdan Jr. wrote: > > Why are these entries needed? > > Done. I realized i could move the whole thing back to ppapi, so these entries > are gone now. Actually, I wasn't able to move it back. I added these entries because the original file had ppapi owners too. content/test/ppapi also has ppapi owners. Paweł Hajdan Jr. 2015/04/17 01:38:01 Please look at the code that's being moved - do yo Show quoted text On 2015/04/16 23:35:42, tommycli wrote: > On 2015/04/16 22:18:51, tommycli wrote: > > On 2015/04/16 21:36:18, Paweł Hajdan Jr. wrote: > > > Why are these entries needed? > > > > Done. I realized i could move the whole thing back to ppapi, so these entries > > are gone now. > > Actually, I wasn't able to move it back. I added these entries because the > original file had ppapi owners too. content/test/ppapi also has ppapi owners. Please look at the code that's being moved - do you have convincing arguments for these ~50 lines having specific OWNERS? tommycli 2015/04/17 20:02:14 Done. I didn't realize you were recommending the r Show quoted text On 2015/04/17 01:38:01, Paweł Hajdan Jr. wrote: > On 2015/04/16 23:35:42, tommycli wrote: > > On 2015/04/16 22:18:51, tommycli wrote: > > > On 2015/04/16 21:36:18, Paweł Hajdan Jr. wrote: > > > > Why are these entries needed? > > > > > > Done. I realized i could move the whole thing back to ppapi, so these > entries > > > are gone now. > > > > Actually, I wasn't able to move it back. I added these entries because the > > original file had ppapi owners too. content/test/ppapi also has ppapi owners. > > Please look at the code that's being moved - do you have convincing arguments > for these ~50 lines having specific OWNERS? Done. I didn't realize you were recommending the removal of these lines.
	9 per-file ppapi*=tommycli@chromium.org

	10 per-file ppapi*=raymes@chromium.org

OLD	NEW

« no previous file with comments | « content/content_tests.gypi ('k') | content/public/test/ppapi_test_utils.h » ('j') | content/public/test/ppapi_test_utils.cc » ('J')