Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1062093002: Update OTS to revision 6d2e08b (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto
Modified:
5 years, 8 months ago
Reviewers:
bashi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update OTS to revision 6d2e08b This brings in a bugfix of checksum calculation that caused assertion failure on debug builds. BUG=464780 Committed: https://crrev.com/3a672fe050438bc787af3f9bb652048291558c6c Cr-Commit-Position: refs/heads/master@{#324023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -131 lines) Patch
M third_party/ots/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/ots/include/opentype-sanitiser.h View 6 chunks +16 lines, -48 lines 0 comments Download
M third_party/ots/src/cmap.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/ots/src/os2.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/ots/src/os2.cc View 10 chunks +78 lines, -41 lines 0 comments Download
M third_party/ots/src/ots.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M third_party/ots/src/woff2.cc View 5 chunks +16 lines, -20 lines 0 comments Download
M third_party/ots/test/ot-sanitise.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/ots/test/side-by-side.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Kunihiko Sakamoto
5 years, 8 months ago (2015-04-07 06:30:00 UTC) #2
bashi
lgtm
5 years, 8 months ago (2015-04-07 07:32:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062093002/1
5 years, 8 months ago (2015-04-07 07:33:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 08:18:50 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3a672fe050438bc787af3f9bb652048291558c6c Cr-Commit-Position: refs/heads/master@{#324023}
5 years, 8 months ago (2015-04-07 08:19:47 UTC) #7
zhaoqin1
5 years, 8 months ago (2015-04-07 15:25:38 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1064913002/ by zhaoqin@chromium.org.

The reason for reverting is: This CL caused many tests fail on uninit read
errors reported by MSan

BUG=474597.

Powered by Google App Engine
This is Rietveld 408576698