Issue 1062053004: Revert of CpuProfiler: public API for deopt info in cpu profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062053004: Revert of CpuProfiler: public API for deopt info in cpu profiler. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach

Modified:
5 years, 8 months ago

Reviewers:
Sven Panne, Jakob Kummerow, alph, yurys, loislo

CC:
Paweł Hajdan Jr., v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of CpuProfiler: public API for deopt info in cpu profiler. (patchset #6 id:150001 of https://codereview.chromium.org/1045753002/) Reason for revert: [Sheriff] Breaks compile here: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6115 Original issue's description: > CpuProfiler: public API for deopt info in cpu profiler. > > BUG=chromium:452067 > LOG=n > > Committed: https://crrev.com/baf927ff5115ec62a6dad684b9232ed9d3960e3a > Cr-Commit-Position: refs/heads/master@{#27626} TBR=alph@chromium.org,jkummerow@chromium.org,svenpanne@chromium.org,yurys@chromium.org,loislo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:452067 Committed: https://crrev.com/74dc9e1710dab07de346f077e0e3dc74c3d09e44 Cr-Commit-Position: refs/heads/master@{#27628}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -44 lines)			Patch
M	include/v8-profiler.h	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/profile-generator.h	View	4 chunks	+13 lines, -5 lines	0 comments	Download
M	src/profile-generator.cc	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	3 chunks	+6 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of CpuProfiler: public API for deopt info in cpu profiler.

5 years, 8 months ago (2015-04-07 13:30:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062053004/1

5 years, 8 months ago (2015-04-07 13:30:42 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 13:31:09 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/74dc9e1710dab07de346f077e0e3dc74c3d09e44
Cr-Commit-Position: refs/heads/master@{#27628}