Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1061993009: cc: Make SingleThreadProxy ignore commit requests inside Layout(). (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, piman, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make SingleThreadProxy ignore commit requests inside Layout(). This makes the SingleThreadProxy match the behaviour of ThreadProxy and ensures that when the embedder is doing Layout() if it changes things that would cause a commit, those things will already happen in the upcoming commit so it does not schedule a second commit afterward. R=enne,vmpstr BUG=466426 Committed: https://crrev.com/fcdaba12b78f0ec947511dd74a418a7754e50c7c Cr-Commit-Position: refs/heads/master@{#326884}

Patch Set 1 #

Patch Set 2 : stp-snc: . #

Patch Set 3 : stp-snc: fixtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -18 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 8 chunks +28 lines, -16 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
danakj
5 years, 8 months ago (2015-04-23 22:19:30 UTC) #2
enne (OOO)
lgtm
5 years, 8 months ago (2015-04-23 22:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061993009/1
5 years, 8 months ago (2015-04-23 22:27:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/58618)
5 years, 8 months ago (2015-04-24 00:40:48 UTC) #7
danakj
PTAL, a few more changes: 1) Create scheduler when STP is created, so that scheduler_on_impl_thread_ ...
5 years, 8 months ago (2015-04-24 19:04:07 UTC) #8
enne (OOO)
lgtm still
5 years, 8 months ago (2015-04-24 19:06:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061993009/40001
5 years, 8 months ago (2015-04-24 20:11:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58917)
5 years, 8 months ago (2015-04-24 20:18:55 UTC) #14
danakj
+sievers for content/
5 years, 8 months ago (2015-04-24 21:02:03 UTC) #16
no sievers
On 2015/04/24 21:02:03, danakj wrote: > +sievers for content/ lgtm
5 years, 8 months ago (2015-04-24 21:03:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061993009/40001
5 years, 8 months ago (2015-04-24 21:04:10 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 21:41:58 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:42:53 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fcdaba12b78f0ec947511dd74a418a7754e50c7c
Cr-Commit-Position: refs/heads/master@{#326884}

Powered by Google App Engine
This is Rietveld 408576698