Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: src/parser.h

Issue 1061983004: Allow eval/arguments in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.js ('k') | src/parser.cc » ('j') | src/parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index 76fbac2a5643ada4b9a92b5b220843802d02eac4..fb05a50749a1dde544b81b03f10af9198611c647 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -753,10 +753,13 @@ class ParserTraits {
V8_INLINE Scope* NewScope(Scope* parent_scope, ScopeType scope_type,
FunctionKind kind = kNormalFunction);
- // Utility functions
- int DeclareArrowParametersFromExpression(Expression* expression, Scope* scope,
- FormalParameterErrorLocations* locs,
- bool* ok);
+ void RecordArrowFunctionParameter(
+ ZoneList<const v8::internal::AstRawString*>* params, VariableProxy* proxy,
arv (Not doing code reviews) 2015/04/13 18:26:38 Why can't this be? ZoneList<const AstRawString*>*
+ FormalParameterErrorLocations* error_locs, bool* ok);
+ ZoneList<const v8::internal::AstRawString*>*
+ ParseArrowFunctionFormalParameterList(
+ Expression* params, const Scanner::Location& params_loc,
+ FormalParameterErrorLocations* error_locs, bool* is_rest, bool* ok);
// Temporary glue; these functions will move to ParserBase.
Expression* ParseV8Intrinsic(bool* ok);
@@ -777,6 +780,9 @@ class ParserTraits {
bool name_is_strict_reserved, int pos,
bool* ok);
+ int DeclareFormalParameters(ZoneList<const AstRawString*>* params,
+ Scope* scope, bool has_rest, bool* ok);
+
V8_INLINE void CheckConflictingVarDeclarations(v8::internal::Scope* scope,
bool* ok);
@@ -1053,8 +1059,6 @@ class Parser : public ParserBase<ParserTraits> {
ScriptCompiler::CompileOptions compile_options_;
ParseData* cached_parse_data_;
- bool parsing_lazy_arrow_parameters_; // for lazily parsed arrow functions.
-
PendingCompilationErrorHandler pending_error_handler_;
// Other information which will be stored in Parser and moved to Isolate after
« no previous file with comments | « src/messages.js ('k') | src/parser.cc » ('j') | src/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698