Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1061933002: Add TPM.InterruptedDuringEarlyCommand cros event enum name. (Closed)

Created:
5 years, 8 months ago by Luigi Semenzato
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TPM.InterruptedDuringEarlyCommand cros event enum name. This gives a name to the event which otherwise will appear on the histogram simply as a number. BUG=chromium:431360 TEST=none Committed: https://crrev.com/8dd986fba19e6248f0e822d908f7d45be0a94dd5 Cr-Commit-Position: refs/heads/master@{#323977}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Luigi Semenzato
Easy, quick review! At your convenience, no hurry! Thanks :)
5 years, 8 months ago (2015-04-06 20:18:21 UTC) #2
Mark P
Sometimes things are not always so easy... -m https://codereview.chromium.org/1061933002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1061933002/diff/1/tools/metrics/histograms/histograms.xml#newcode42227 tools/metrics/histograms/histograms.xml:42227: + ...
5 years, 8 months ago (2015-04-06 21:34:18 UTC) #3
Luigi Semenzato
On 2015/04/06 21:34:18, Mark P wrote: > Sometimes things are not always so easy... > ...
5 years, 8 months ago (2015-04-06 21:39:09 UTC) #4
Mark P
lgtm
5 years, 8 months ago (2015-04-06 22:02:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061933002/20001
5 years, 8 months ago (2015-04-06 22:18:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 23:28:22 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 23:29:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8dd986fba19e6248f0e822d908f7d45be0a94dd5
Cr-Commit-Position: refs/heads/master@{#323977}

Powered by Google App Engine
This is Rietveld 408576698