Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 106193004: Introduce DEFINE_IMAGE_TYPE_CASTS, and use it (Closed)

Created:
7 years ago by gyuyoung-inactive
Modified:
7 years ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, krit, dsinclair, danakj, Rik, f(malita), pdr, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce DEFINE_IMAGE_TYPE_CASTS, and use it As a step to use DEFINE_TYPE_CASTS, this cl introduce DEFINE_IMAGE_TYPE_CASTS. BitmapImage, SVGImage can use it to generate toFoo() type case helper functions. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163382

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/core/fetch/ImageResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/DragImage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/graphics/Image.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gyuyoung-inactive
7 years ago (2013-12-06 02:08:29 UTC) #1
tkent
lgtm
7 years ago (2013-12-06 03:12:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/106193004/1
7 years ago (2013-12-06 03:13:37 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/platform/graphics/BitmapImage.h: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years ago (2013-12-06 13:14:54 UTC) #4
gyuyoung-inactive
On 2013/12/06 13:14:54, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
7 years ago (2013-12-07 06:30:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/106193004/20001
7 years ago (2013-12-08 13:15:04 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-08 14:17:21 UTC) #7
Message was sent while issue was closed.
Change committed as 163382

Powered by Google App Engine
This is Rietveld 408576698