Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: runtime/bin/vmservice/server.dart

Issue 106193003: Cleanup VM service (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/running_isolates.dart ('k') | runtime/bin/vmservice/service_request.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/server.dart
diff --git a/runtime/bin/vmservice/server.dart b/runtime/bin/vmservice/server.dart
index 7992b3b091f6e854b345bb418c313a47f5a08996..19490a13a6fbf8edb159097ae982de618a70029a 100644
--- a/runtime/bin/vmservice/server.dart
+++ b/runtime/bin/vmservice/server.dart
@@ -12,6 +12,12 @@ class Server {
Server(this.service, this.port);
+ void _sendResponse(HttpRequest request, String response) {
+ request.response..headers.contentType = jsonContentType
+ ..write(response)
+ ..close();
+ }
+
void _requestHandler(HttpRequest request) {
// Allow cross origin requests.
request.response.headers.add('Access-Control-Allow-Origin', '*');
@@ -31,27 +37,17 @@ class Server {
var serviceRequest = new ServiceRequest();
var r = serviceRequest.parse(request.uri);
- if (!r) {
- // Did not understand the request uri.
- serviceRequest.setErrorResponse('Invalid request uri: ${request.uri}');
- } else {
+ if (r) {
var f = service.runningIsolates.route(serviceRequest);
- if (f != null) {
- f.then((_) {
- request.response.headers.contentType = jsonContentType;
- request.response.write(serviceRequest.response);
- request.response.close();
- }).catchError((e) { });
- return;
- } else {
- // Nothing responds to this type of request.
- serviceRequest.setErrorResponse('No route for: $path');
- }
+ assert(f != null);
+ f.then((_) {
+ _sendResponse(request, serviceRequest.response);
+ }).catchError((e) {
+ // Error replying over HTTP.
+ });
+ return;
}
-
- request.response.headers.contentType = jsonContentType;
- request.response.write(serviceRequest.response);
- request.response.close();
+ _sendResponse(request, serviceRequest.response);
}
Future startServer() {
« no previous file with comments | « runtime/bin/vmservice/running_isolates.dart ('k') | runtime/bin/vmservice/service_request.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698