Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/vmservice/service_request.dart

Issue 106193003: Cleanup VM service (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/vmservice/server.dart ('K') | « runtime/bin/vmservice/server.dart ('k') | runtime/bin/vmservice/vmservice.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/service_request.dart
diff --git a/runtime/bin/vmservice/service_request.dart b/runtime/bin/vmservice/service_request.dart
index 4724d7cb6dd2f5d4a993adfc05a77998661cf295..8d7eb521e6298112ac8c724efd4f11c09e10f4ea 100644
--- a/runtime/bin/vmservice/service_request.dart
+++ b/runtime/bin/vmservice/service_request.dart
@@ -16,6 +16,7 @@ class ServiceRequest {
var path = uri.path;
var split = path.split('/');
if (split.length == 0) {
+ setErrorResponse('Invalid request uri: ${request.uri}');
return false;
}
for (int i = 0; i < split.length; i++) {
@@ -37,7 +38,7 @@ class ServiceRequest {
void setErrorResponse(String error) {
_response = JSON.encode({
- 'type': 'error',
+ 'type': 'Error',
'msg': error,
'pathSegments': pathSegments,
'parameters': parameters
« runtime/bin/vmservice/server.dart ('K') | « runtime/bin/vmservice/server.dart ('k') | runtime/bin/vmservice/vmservice.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698