Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1061903004: Cleanup: Match the declaration order of MD5Sum() with the definition. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Match the declaration order of MD5Sum() with the definition. This puts the declaration of MD5Sum() function in sync with the definition, which is right after MD5DigestToBase16() in the source file, so it should be in the header file as well. BUG=None TEST=base_unittests --gtest_filter=MD5* R=thestig@chromium.org Committed: https://crrev.com/709579eedbd4c8a5d116398bd8b76e7c13366c22 Cr-Commit-Position: refs/heads/master@{#324058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/md5.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 8 months ago (2015-04-06 21:49:22 UTC) #1
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-06 21:54:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061903004/1
5 years, 8 months ago (2015-04-07 14:04:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 16:57:26 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 17:01:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/709579eedbd4c8a5d116398bd8b76e7c13366c22
Cr-Commit-Position: refs/heads/master@{#324058}

Powered by Google App Engine
This is Rietveld 408576698