Disable chromoting service on permanent errors.

remoting/host/daemon_process_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/daemon_process.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
@@ skipping 122 matching lines @@
 
   if (!InitializePairingRegistry()) {
     CrashNetworkProcess(FROM_HERE);
     return;
   }
 
   DaemonProcess::OnChannelConnected(peer_pid);
 }
 
 void DaemonProcessWin::OnPermanentError(int exit_code) {
-  // Change the service start type to 'manual' if the host has been deleted
-  // remotely. This way the host will not be started every time the machine
-  // boots until the user re-enable it again.
-  if (exit_code == kInvalidHostIdExitCode)
+  DCHECK(kMinPermanentErrorExitCode <= exit_code &&
+         exit_code <= kMaxPermanentErrorExitCode);
+
+  // Change the service start type to 'manual' if the host has been unregistered
+  // in the remoting host directory. This way the host will not be started every
+  // time the machine boots until the user re-enable it again.
+  // For regular accounts, the exit_code will be kInvalidHostIdExitCode.
+  // For service accounts, the exit_code will be
+  // kInvalidOauthCredentialsExitCode. This is because when a host is deleted
+  // the service account is deleted as well, which revokes the auth token, so
+  // the host is no longer able to authenticate.

[Sergey Ulanov, 2015/04/07 21:50:18]

This description is too wordy. I don't think you need that many details here.
e.g. it's not necessary to mention service accounts. There are 2 types of
"permanent" errors:
 1. Errors that may go away without changes to the host config. This happens
mainly when the host fails to start due to policies, e.g.
kInvalidHostDomainExitCode.
 2. Errors that will never go away with the current config.

kInvalidHostIdExitCode and kInvalidOauthCredentialsExitCode are in the second
category. For such errors we want the service to be disabled. It's assumed that
the service will be re-enabled whenever the config is updated. 

+  if (exit_code == kInvalidHostIdExitCode ||
+      exit_code == kInvalidOauthCredentialsExitCode) {
     DisableAutoStart();
+  }
 
   DaemonProcess::OnPermanentError(exit_code);
 }
 
 void DaemonProcessWin::SendToNetwork(IPC::Message* message) {
   if (network_launcher_) {
     network_launcher_->Send(message);
   } else {
     delete message;
   }
@@ skipping 213 matching lines @@
                 << "\\" << kPairingRegistrySecretsKeyName;
     return false;
   }
 
   pairing_registry_privileged_key_.Set(privileged.Take());
   pairing_registry_unprivileged_key_.Set(unprivileged.Take());
   return true;
 }
 
 }  // namespace remoting