Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1061833002: Add epub mime type. (Closed)

Created:
5 years, 8 months ago by yawano
Modified:
5 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, kinaba, Seigo Nonaka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add epub mime type. BUG=473561 TEST=none Committed: https://crrev.com/7e939708c86329e3c1bf04c7b9c728df1400ab9d Cr-Commit-Position: refs/heads/master@{#324008}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/base/mime_util.cc View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
yawano
Could you take a look at this CL? Thank you!
5 years, 8 months ago (2015-04-06 05:49:36 UTC) #2
eroman
lgtm https://codereview.chromium.org/1061833002/diff/1/net/base/mime_util.cc File net/base/mime_util.cc (right): https://codereview.chromium.org/1061833002/diff/1/net/base/mime_util.cc#newcode229 net/base/mime_util.cc:229: { "application/epub+zip", "epub" }, Is there any details ...
5 years, 8 months ago (2015-04-06 19:10:19 UTC) #3
yawano
Thank you for the review! https://codereview.chromium.org/1061833002/diff/1/net/base/mime_util.cc File net/base/mime_util.cc (right): https://codereview.chromium.org/1061833002/diff/1/net/base/mime_util.cc#newcode229 net/base/mime_util.cc:229: { "application/epub+zip", "epub" }, ...
5 years, 8 months ago (2015-04-07 02:00:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061833002/1
5 years, 8 months ago (2015-04-07 02:25:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 03:23:11 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 03:23:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e939708c86329e3c1bf04c7b9c728df1400ab9d
Cr-Commit-Position: refs/heads/master@{#324008}

Powered by Google App Engine
This is Rietveld 408576698