Issue 106183010: Delete 2 redundant bindings tests: TestExtendedEvent.idl and TestEvent.idl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106183010: Delete 2 redundant bindings tests: TestExtendedEvent.idl and TestEvent.idl (Closed)

Created:
7 years ago by Nils Barth (inactive)

Modified:
7 years ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Delete 2 redundant bindings tests: TestExtendedEvent.idl and TestEvent.idl TestExtendedEvent.idl and TestEvent.idl are superseded by the much more comprehensive TestInterfaceEventConstructor.idl, and do not test anything separate, so delete. NOTRY=true TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163752

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -793 lines)			Patch
D	Source/bindings/tests/idls/TestEvent.idl	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	Source/bindings/tests/idls/TestExtendedEvent.idl	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	Source/bindings/tests/results/EventInterfaces.in	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/bindings/tests/results/V8TestEvent.h	View	1 chunk	+0 lines, -160 lines	0 comments	Download
D	Source/bindings/tests/results/V8TestEvent.cpp	View	1 chunk	+0 lines, -149 lines	0 comments	Download
D	Source/bindings/tests/results/V8TestExtendedEvent.h	View	1 chunk	+0 lines, -166 lines	0 comments	Download
D	Source/bindings/tests/results/V8TestExtendedEvent.cpp	View	1 chunk	+0 lines, -248 lines	0 comments	Download
M	Tools/Scripts/webkitpy/bindings/main.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/106183010/1

7 years ago (2013-12-12 05:13:48 UTC) #2

Message was sent while issue was closed.

Change committed as 163752

Expand Messages | Collapse Messages