Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1061803004: Add tool/perf/measurements path to check for CQ jobs. (Closed)

Created:
5 years, 8 months ago by prasadv
Modified:
5 years, 7 months ago
Reviewers:
nednguyen, qyearsley
CC:
chromium-reviews, auto-bisect-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tool/perf/measurements path to check for CQ jobs. BUG=462581 Committed: https://crrev.com/99e1ac1d217174dad7a862f6a0fc44950d503737 Cr-Commit-Position: refs/heads/master@{#325296}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/run-bisect-perf-regression.py View 2 chunks +3 lines, -1 line 2 comments Download

Messages

Total messages: 11 (3 generated)
prasadv
5 years, 8 months ago (2015-04-15 19:55:21 UTC) #2
qyearsley
On 2015/04/15 19:55:21, prasadv wrote: LGTM
5 years, 8 months ago (2015-04-15 19:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061803004/1
5 years, 8 months ago (2015-04-15 20:06:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 20:46:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99e1ac1d217174dad7a862f6a0fc44950d503737 Cr-Commit-Position: refs/heads/master@{#325296}
5 years, 8 months ago (2015-04-15 20:47:12 UTC) #7
nednguyen
https://codereview.chromium.org/1061803004/diff/1/tools/run-bisect-perf-regression.py File tools/run-bisect-perf-regression.py (right): https://codereview.chromium.org/1061803004/diff/1/tools/run-bisect-perf-regression.py#newcode640 tools/run-bisect-perf-regression.py:640: benchmark = os.path.basename(os.path.splitext(affected_file)[0]) This seems to make the assumption ...
5 years, 7 months ago (2015-04-27 22:02:54 UTC) #9
prasadv
https://codereview.chromium.org/1061803004/diff/1/tools/run-bisect-perf-regression.py File tools/run-bisect-perf-regression.py (right): https://codereview.chromium.org/1061803004/diff/1/tools/run-bisect-perf-regression.py#newcode640 tools/run-bisect-perf-regression.py:640: benchmark = os.path.basename(os.path.splitext(affected_file)[0]) On 2015/04/27 22:02:54, nednguyen wrote: > ...
5 years, 7 months ago (2015-04-27 22:14:50 UTC) #10
nednguyen
5 years, 7 months ago (2015-04-27 22:23:09 UTC) #11
Message was sent while issue was closed.
On 2015/04/27 22:14:50, prasadv wrote:
>
https://codereview.chromium.org/1061803004/diff/1/tools/run-bisect-perf-regre...
> File tools/run-bisect-perf-regression.py (right):
> 
>
https://codereview.chromium.org/1061803004/diff/1/tools/run-bisect-perf-regre...
> tools/run-bisect-perf-regression.py:640: benchmark =
> os.path.basename(os.path.splitext(affected_file)[0])
> On 2015/04/27 22:02:54, nednguyen wrote:
> > This seems to make the assumption that benchmark's name is the same as
> > measurement name? Note that this may not always be True.
> 
> Is there any way to find measurement to benchmark mapping?

You can iterate through all benchmark files in benchmark/ folder, then for each
benchmark file, find the list all imported modules in that file that match the
module of the changed measurement files. If the list is non empty, then the
benchmark is "modified".

Powered by Google App Engine
This is Rietveld 408576698