Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1061753009: add GM to show bad banding in raster for radial gradients (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add GM to show bad banding in raster for radial gradients BUG=427508 TBR= Committed: https://skia.googlesource.com/skia/+/3d9005c0286f2dff8f3db030c4c1ad19371deebd

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M gm/gradients.cpp View 1 8 chunks +32 lines, -18 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
reed1
5 years, 8 months ago (2015-04-23 17:15:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061753009/1
5 years, 8 months ago (2015-04-23 17:15:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061753009/20001
5 years, 8 months ago (2015-04-23 17:24:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3d9005c0286f2dff8f3db030c4c1ad19371deebd
5 years, 8 months ago (2015-04-23 17:30:30 UTC) #7
robertphillips
5 years, 8 months ago (2015-04-23 18:48:18 UTC) #8
Message was sent while issue was closed.
lgtm + trivial nit

https://codereview.chromium.org/1061753009/diff/20001/gm/gradients.cpp
File gm/gradients.cpp (right):

https://codereview.chromium.org/1061753009/diff/20001/gm/gradients.cpp#newcod...
gm/gradients.cpp:450: fShader.reset(SkGradientShader::CreateRadial(center,
kRadius, gColors, NULL, 2,
missing space ?

Powered by Google App Engine
This is Rietveld 408576698