Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1061753008: Revert of Remove the weak list of views from array buffers (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove the weak list of views from array buffers (patchset #6 id:100001 of https://codereview.chromium.org/1094863002/) Reason for revert: I'm reverting this while working on the regression fix Original issue's description: > Remove the weak list of views from array buffers > > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c > Cr-Commit-Position: refs/heads/master@{#27995} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169 Cr-Commit-Position: refs/heads/master@{#28014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+864 lines, -475 lines) Patch
M src/accessors.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/elements.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/elements.cc View 8 chunks +14 lines, -22 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/factory.cc View 5 chunks +12 lines, -87 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/heap/heap.h View 5 chunks +32 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 8 chunks +29 lines, -1 line 0 comments Download
M src/heap/objects-visiting.cc View 4 chunks +79 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 6 chunks +24 lines, -4 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +27 lines, -60 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +10 lines, -5 lines 0 comments Download
M src/objects.h View 16 chunks +54 lines, -50 lines 0 comments Download
M src/objects.cc View 4 chunks +154 lines, -142 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/objects-inl.h View 2 chunks +20 lines, -78 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 6 chunks +62 lines, -0 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 2 chunks +295 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Remove the weak list of views from array buffers
5 years, 8 months ago (2015-04-22 15:03:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061753008/1
5 years, 8 months ago (2015-04-22 15:03:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 15:03:30 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 15:03:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169
Cr-Commit-Position: refs/heads/master@{#28014}

Powered by Google App Engine
This is Rietveld 408576698