Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1061753002: QUIC - Updated QuicErrorCodes with the new error codes. (Closed)

Created:
5 years, 8 months ago by ramant (doing other things)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Updated QuicErrorCodes with the new error codes. Per net/quic/quic_protocol.h around line# 521. R=asvitkine@chromium.org, rch@chromium.org, isherman@chromium.org Committed: https://crrev.com/52feb04d7c56451d22a5d4a9f82a820af0a50e34 Cr-Commit-Position: refs/heads/master@{#323945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ramant (doing other things)
5 years, 8 months ago (2015-04-04 01:36:53 UTC) #1
Ryan Hamilton
lgtm Sorry for the delay.
5 years, 8 months ago (2015-04-06 14:49:03 UTC) #2
ramant (doing other things)
Hi isherman, Could you take a look at this change, Alexei seems to be OOO. ...
5 years, 8 months ago (2015-04-06 16:27:51 UTC) #4
Ilya Sherman
lgtm
5 years, 8 months ago (2015-04-06 18:27:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061753002/1
5 years, 8 months ago (2015-04-06 18:27:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 21:01:53 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:02:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52feb04d7c56451d22a5d4a9f82a820af0a50e34
Cr-Commit-Position: refs/heads/master@{#323945}

Powered by Google App Engine
This is Rietveld 408576698