Issue 1061743002: Add more dirs to gn check set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1061743002: Add more dirs to gn check set (Closed)

Created:
5 years, 8 months ago by jamesr

Modified:
5 years, 8 months ago

Reviewers:
tonyg

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add more dirs to gn check set We maintain these all ourselves now and they 'gn check' clean so add them to the default check set so they stay working. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/63d51d0d2a65baab1d3bc99eacf4fb628c818661

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -9 lines)			Patch
M	.gn	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	cc/BUILD.gn	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	gin/BUILD.gn	View	3 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

jamesr

5 years, 8 months ago (2015-04-04 00:17:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
63d51d0d2a65baab1d3bc99eacf4fb628c818661 (presubmit successful).