Issue 1061713003: Revert of Adding bulk plot reffer to cached textblobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1061713003: Revert of Adding bulk plot reffer to cached textblobs (Closed)

Created:
5 years, 8 months ago by joshualitt

Modified:
5 years, 8 months ago

Reviewers:
jvanverth1, bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@atlastext

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Adding bulk plot reffer to cached textblobs (patchset #7 id:110001 of https://codereview.chromium.org/1050113004/) Reason for revert: Breaks linux builder Original issue's description: > Adding bulk plot reffer to cached textblobs > > This change will prevent the atlas from evicting glyphs the TextBlob > needs. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2 TBR=bsalomon@google.com,jvanverth@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3cf9863bb658d637416c4edbf278b0311dba7478

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -112 lines)			Patch
M	src/gpu/GrAADistanceFieldPathRenderer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrAtlasTextContext.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrAtlasTextContext.cpp	View	3 chunks	+2 lines, -9 lines	0 comments	Download
M	src/gpu/GrBatchAtlas.h	View	2 chunks	+3 lines, -48 lines	0 comments	Download
M	src/gpu/GrBatchAtlas.cpp	View	10 chunks	+29 lines, -32 lines	0 comments	Download
M	src/gpu/GrBatchFontCache.h	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/gpu/GrBatchFontCache.cpp	View	1 chunk	+3 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of Adding bulk plot reffer to cached textblobs

5 years, 8 months ago (2015-04-07 17:21:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061713003/1

5 years, 8 months ago (2015-04-07 17:21:15 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 17:21:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3cf9863bb658d637416c4edbf278b0311dba7478