Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1061713002: Update minSdkVersion and targetSdkVersion constants. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, klundberg+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, pfeldman, yfriedman+watch_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update minSdkVersion and targetSdkVersion constants. - Chrome has been targetting 22 for a while now so updating to match it. - Chrome has deprecated ICS so raising minSdkVersion to 16. BUG=473837 Committed: https://crrev.com/1d807cd78fe35e59218b1cb9a78a93a13a4b0e10 Cr-Commit-Position: refs/heads/master@{#323947}

Patch Set 1 #

Messages

Total messages: 14 (5 generated)
aurimas (slooooooooow)
PTAL at this small change.
5 years, 8 months ago (2015-04-03 23:01:53 UTC) #4
jbudorick
build/android/ lgtm
5 years, 8 months ago (2015-04-03 23:05:18 UTC) #5
mnaganov (inactive)
components/devtools_bridge LGTM
5 years, 8 months ago (2015-04-04 14:05:08 UTC) #6
aurimas (slooooooooow)
yfriedman: ping?
5 years, 8 months ago (2015-04-06 17:52:30 UTC) #7
aurimas (slooooooooow)
(since I could not reach yfriedman) +tedchoc to look at: chrome/* content/*
5 years, 8 months ago (2015-04-06 19:42:42 UTC) #9
Ted C
On 2015/04/06 19:42:42, aurimas wrote: > (since I could not reach yfriedman) +tedchoc to look ...
5 years, 8 months ago (2015-04-06 20:13:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061713002/1
5 years, 8 months ago (2015-04-06 20:14:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 21:03:20 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:04:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d807cd78fe35e59218b1cb9a78a93a13a4b0e10
Cr-Commit-Position: refs/heads/master@{#323947}

Powered by Google App Engine
This is Rietveld 408576698