Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1061703003: Localize the Accessibility Page. (Closed)

Created:
5 years, 8 months ago by Kyle Horimoto
Modified:
5 years, 8 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Localize the Accessibility Page. BUG=472677 Committed: https://crrev.com/6f6eba38275695220ec63e358d83d9e3b548c7ad Cr-Commit-Position: refs/heads/master@{#323952}

Patch Set 1 #

Patch Set 2 : a11y page finished. #

Patch Set 3 : Disable CrOS-only settings when not on CrOS. #

Total comments: 2

Patch Set 4 : Organized .grdp and .cc file by page. #

Total comments: 2

Patch Set 5 : jhawkins nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -24 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 2 1 chunk +34 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 1 chunk +66 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Kyle Horimoto
5 years, 8 months ago (2015-04-06 18:58:19 UTC) #2
James Hawkins
https://codereview.chromium.org/1061703003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/1061703003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc#newcode25 chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:25: html_source->AddLocalizedString( Let's break this up into subfunctions.
5 years, 8 months ago (2015-04-06 19:04:38 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/1061703003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/1061703003/diff/40001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc#newcode25 chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:25: html_source->AddLocalizedString( On 2015/04/06 19:04:38, James Hawkins wrote: > Let's ...
5 years, 8 months ago (2015-04-06 20:15:47 UTC) #4
James Hawkins
LGTM with nit. https://codereview.chromium.org/1061703003/diff/60001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1061703003/diff/60001/chrome/app/settings_strings.grdp#newcode4 chrome/app/settings_strings.grdp:4: <!-- Accessibility Page. --> nit: I ...
5 years, 8 months ago (2015-04-06 20:17:21 UTC) #5
Kyle Horimoto
https://codereview.chromium.org/1061703003/diff/60001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1061703003/diff/60001/chrome/app/settings_strings.grdp#newcode4 chrome/app/settings_strings.grdp:4: <!-- Accessibility Page. --> On 2015/04/06 20:17:21, James Hawkins ...
5 years, 8 months ago (2015-04-06 20:19:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061703003/80001
5 years, 8 months ago (2015-04-06 20:20:28 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-06 21:13:18 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:14:22 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/6f6eba38275695220ec63e358d83d9e3b548c7ad
Cr-Commit-Position: refs/heads/master@{#323952}

Powered by Google App Engine
This is Rietveld 408576698