Fixed logic for display of upgrade menu item.

chrome/browser/upgrade_detector.h

Index: chrome/browser/upgrade_detector.h
diff --git a/chrome/browser/upgrade_detector.h b/chrome/browser/upgrade_detector.h
index 53e8ee318e80c1cc6740b4b61f8d3d699ea4b537..e117a67c48d3bbadc8ac1a31caafac1d492f24de 100644
--- a/chrome/browser/upgrade_detector.h
+++ b/chrome/browser/upgrade_detector.h
@@ -132,6 +132,8 @@ class UpgradeDetector {
   }
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(WrenchMenuModelTest, Basics);

[msw, 2015/04/23 22:06:42]

Why does this need to be a friend test? It looks like it just uses public API.

[Lei Zhang, 2015/04/23 22:08:22]

The methods are protected, not public.

[msw, 2015/04/23 22:11:28]

Ah, missed that, sorry!

[Albert Bodenhamer, 2015/04/23 22:26:48]

Yep. Protected. There were a bunch of ways to go here. This seemed simplest, but
I'm never a fan of friend.

+
   // Initiates an Idle check. See IdleCallback below.
   void CheckIdle();