Issue 106163004: Add Windows compilation support to V8 example

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106163004: Add Windows compilation support to V8 example (Closed)

Created:
7 years ago by robertphillips

Modified:
7 years ago

Reviewers:
jcgregorio

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Not pretty but it works. We will have to get some gyp expert to clean this all up later.

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	gyp/v8.gyp	View		1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jcgregorio

lgtm https://codereview.chromium.org/106163004/diff/1/gyp/v8.gyp File gyp/v8.gyp (right): https://codereview.chromium.org/106163004/diff/1/gyp/v8.gyp#newcode30 gyp/v8.gyp:30: # 'd:/src/v8/build/Debug/lib/icui18n.lib', I think you can just add ...

7 years ago (2013-12-05 15:47:06 UTC) #2

Message was sent while issue was closed.

committed as r12508

Expand Messages | Collapse Messages