Refactor IPC fuzzer.

tools/ipc_fuzzer/replay/replay_process.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+

[Tom Sepez, 2013/12/05 19:05:49]

Please put an include guard macro in this file.

[aedla, 2013/12/05 23:16:21]

Good catch.

+#include <list>
+
+#include "base/files/memory_mapped_file.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/synchronization/waitable_event.h"
+#include "base/threading/thread.h"
+#include "base/timer/timer.h"
+#include "ipc/ipc_channel_proxy.h"
+#include "ipc/ipc_listener.h"
+#include "ipc/ipc_message.h"
+
+namespace ipc_fuzzer {
+
+class ReplayProcess : public IPC::Listener {
+ public:
+  ReplayProcess();
+  virtual ~ReplayProcess();
+
+  // Set up command line, logging, IO thread.
+  void Initialize(int argc, const char **argv);

[Tom Sepez, 2013/12/05 19:05:49]

nit: probably needs to be a bool to fail execution if someone passes wacky flags
...

[aedla, 2013/12/05 23:16:21]

Done.

+
+  // Open a channel to the browser process. It will think we are a renderer.
+  void OpenChannel();

[Tom Sepez, 2013/12/05 19:05:49]

Nit: probably needs to be a bool to return status.

[aedla, 2013/12/05 23:16:21]

OpenChannel() can't really fail. Wrote a bit longer in a replay.cc comment.

+
+  // Extract messages from a file specified by --ipc-fuzzer-testcase=.
+  bool OpenTestcase();

[Tom Sepez, 2013/12/05 19:05:49]

Nit: // returns true on success, false otherwise.

[aedla, 2013/12/05 23:16:21]

Done.

+
+  // Send messages to the browser.
+  void Run();
+
+  // IPC::Listener implementation.
+  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+  virtual void OnChannelError() OVERRIDE;
+
+ private:
+  bool ExtractMessages(const char *data, size_t len);
+  void SendNextMessage();
+
+  scoped_ptr<IPC::ChannelProxy> channel_;
+  base::MessageLoop main_loop_;
+  base::Thread io_thread_;
+  base::WaitableEvent shutdown_event_;
+  scoped_ptr<base::Timer> timer_;
+  scoped_ptr<base::MemoryMappedFile> testcase_map_;

[Tom Sepez, 2013/12/05 19:05:49]

nit: testcase_mapped_file_, otherwise the name sounds like a std::map.

[aedla, 2013/12/05 23:16:21]

Went with mapped_testcase_.

+  std::list<IPC::Message*> messages_;
+
+  DISALLOW_COPY_AND_ASSIGN(ReplayProcess);
+};
+
+}  // namespace ipc_fuzzer