chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm - Issue 1061623002: [Toolbar Mac UI] Simplify and correct omnibox pinning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm

Issue 1061623002: [Toolbar Mac UI] Simplify and correct omnibox pinning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm ('k') | chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm

index 2d7ea837bc84643b48b7a356f2f31b278b59a798..737f1b789a965fa0d718df0b3a81eb5fa62cd1b2 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm

@@ -49,17 +49,12 @@ TEST_F(BrowserActionsContainerViewTest, SetWidthTests) {

[view_ resizeToWidth:kMinimumContainerWidth - 1 animate:NO];

EXPECT_EQ(kMinimumContainerWidth, NSWidth([view_ frame])) << "Frame width is "

<< "less than the minimum allowed.";

- // Since the frame expands to the left, the x-position delta value will be

- // negative.

- EXPECT_EQ(-kMinimumContainerWidth, [view_ resizeDeltaX]);

[view_ resizeToWidth:35.0 animate:NO];

EXPECT_EQ(35.0, NSWidth([view_ frame]));

- EXPECT_EQ(kMinimumContainerWidth - 35.0, [view_ resizeDeltaX]);

[view_ resizeToWidth:20.0 animate:NO];

EXPECT_EQ(20.0, NSWidth([view_ frame]));

- EXPECT_EQ(15.0, [view_ resizeDeltaX]);

// Resize the view with animation. It shouldn't immediately take the new

// value, but the animationEndFrame should reflect the pending change.