chrome/browser/extensions/api/settings_private/settings_private_delegate.h - Issue 1061613002: chrome.settingsPrivate: Implement onPrefsChanged event handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_private/settings_private_delegate.h

Issue 1061613002: chrome.settingsPrivate: Implement onPrefsChanged event handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to Steven's comments + add an APItest Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/settings_private/settings_private_apitest.cc ('K') | « chrome/browser/extensions/api/settings_private/settings_private_apitest.cc ('k') | chrome/browser/extensions/api/settings_private/settings_private_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_private/settings_private_delegate.h

diff --git a/chrome/browser/extensions/api/settings_private/settings_private_delegate.h b/chrome/browser/extensions/api/settings_private/settings_private_delegate.h

index 2c608a46f827d056347151839f880e88df1ec251..96405f31696c2ea1cd4a79034a167ed5668f9920 100644

--- a/chrome/browser/extensions/api/settings_private/settings_private_delegate.h

+++ b/chrome/browser/extensions/api/settings_private/settings_private_delegate.h

@@ -11,7 +11,6 @@

#include "base/callback.h"

#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

-#include "chrome/browser/profiles/profile.h"

#include "chrome/common/extensions/api/settings_private.h"

#include "components/keyed_service/core/keyed_service.h"

#include "extensions/browser/extension_function.h"

@@ -43,11 +42,10 @@ class SettingsPrivateDelegate : public KeyedService {

// Gets the values of all whitelisted prefs.

virtual scoped_ptr<base::Value> GetAllPrefs();

- private:

- PrefService* FindServiceForPref(const std::string& pref_name);

+ protected:

Profile* profile_; // weak; not owned by us

+ private:

DISALLOW_COPY_AND_ASSIGN(SettingsPrivateDelegate);

};