Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: webkit/tools/test_shell/mac/test_webview_delegate.mm

Issue 10616: Roll back Rietveld issue 8778 (r5183, appending stderr to layout-test output)... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/mac/test_webview_delegate.mm
===================================================================
--- webkit/tools/test_shell/mac/test_webview_delegate.mm (revision 5205)
+++ webkit/tools/test_shell/mac/test_webview_delegate.mm (working copy)
@@ -85,13 +85,7 @@
void TestWebViewDelegate::DidStartLoading(WebView* webview) {
if (page_is_loading_) {
- // When we started including stderr in layout-test output, a number of
- // number of tests began failing. The vast majority of the new failures
- // were due to either this error message or the one in DidStopLoading.
- // This is being disabled temporarily so we can keep running the tests.
- // See http://code.google.com/p/chromium/issues/detail?id=3937
- // TODO(pamg): Remove this when the underlying bug is fixed.
- //LOG(ERROR) << "DidStartLoading called while loading";
+ LOG(ERROR) << "DidStartLoading called while loading";
return;
}
page_is_loading_ = true;
@@ -99,13 +93,7 @@
void TestWebViewDelegate::DidStopLoading(WebView* webview) {
if (!page_is_loading_) {
- // When we started including stderr in layout-test output, a number of
- // number of tests began failing. The vast majority of the new failures
- // were due to either this error message or the one in DidStartLoading.
- // This is being disabled temporarily so we can keep running the tests.
- // See http://code.google.com/p/chromium/issues/detail?id=3937
- // TODO(pamg): Remove this when the underlying bug is fixed.
- //LOG(ERROR) << "DidStopLoading called while not loading";
+ LOG(ERROR) << "DidStopLoading called while not loading";
return;
}
page_is_loading_ = false;
« no previous file with comments | « webkit/tools/layout_tests/test_lists/win/tests_fixable.txt ('k') | webkit/tools/test_shell/test_shell_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698