Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1061543006: Pull in the latest upstream testharness.js changes. (Closed)

Created:
5 years, 8 months ago by jsbell
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Pull in the latest upstream testharness.js changes. This pull in the latest changes from the testharness.js repository: https://github.com/w3c/testharness.js Bug fixes, new idlharness functionality, and so on. This is required for importing new/updated tests from web-platform-tests. Mainly just a copy/paste of testharness.js and idlharness.js. A few failing expectations needed updating due to output changes, and one test that now spews a stack is tweaked to use testharnessreport.js to ensure consistent output across our bots. R=dpranke@chromium.org BUG=433962 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194416

Patch Set 1 #

Patch Set 2 : Rebase/tweaks for affected tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2460 lines, -3186 lines) Patch
M LayoutTests/http/tests/resources/testharness.js View 24 chunks +179 lines, -447 lines 0 comments Download
M LayoutTests/http/tests/security/suborigins/multiple-suborigins-disallowed-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-allow-in-http-header-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-blocked-different-suborigins-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-blocked-not-in-suborigin-to-suborigin-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-change-document-domain-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-document-suborigin-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-invalid-names-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-valid-names-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/w3c/resources/idlharness.js View 28 chunks +624 lines, -797 lines 0 comments Download
M LayoutTests/http/tests/w3c/resources/testharness.js View 47 chunks +837 lines, -674 lines 0 comments Download
M LayoutTests/http/tests/w3c/webperf/resources/idlharness.js View 28 chunks +624 lines, -797 lines 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTMLCrash.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTMLCrash-expected.txt View 1 1 chunk +6 lines, -14 lines 0 comments Download
M LayoutTests/resources/testharness.js View 24 chunks +179 lines, -447 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jsbell
dpranke@ - please take a look? Just copy/paste from tip-of-tree to all findable copies of ...
5 years, 8 months ago (2015-04-23 23:47:56 UTC) #1
Dirk Pranke
rubber-stamp lgtm. Should we be importing the docs/ directory that these files all reference, now?
5 years, 8 months ago (2015-04-24 00:38:10 UTC) #2
jsbell
On 2015/04/24 00:38:10, Dirk Pranke wrote: > Should we be importing the docs/ directory that ...
5 years, 8 months ago (2015-04-24 18:15:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061543006/20001
5 years, 8 months ago (2015-04-24 18:18:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/35886)
5 years, 8 months ago (2015-04-24 18:24:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061543006/20001
5 years, 8 months ago (2015-04-24 18:52:18 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 20:03:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194416

Powered by Google App Engine
This is Rietveld 408576698