Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1061533006: Truncate long URL fragments in Android page info popup (Closed)

Created:
5 years, 8 months ago by benwells
Modified:
5 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

Truncate long URL fragments in Android page info popup This replaces percent-encoding whitespace as a method to combat the use of crafted URL fragments to inject messages into the page info popup. By truncating the URL so that at most two lines of the fragment are shown, we prevent lengthy messages from being injected while minimising the effect on most URLs. BUG=466351 Review URL: https://codereview.chromium.org/1077483002 Merged from trunk. TBR=tedchoc@chromium.org Cr-Commit-Position: refs/heads/master@{#325358} (cherry picked from commit 5bf8a2dccf4777c5f065d918d1d9a2bbaa013f9f) Committed: https://chromium.googlesource.com/chromium/src/+/5aba40cebe8c915c114f3d6ffd10a0c29f0f77d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -81 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 7 chunks +41 lines, -41 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/WebsiteSettingsPopupTest.java View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
benwells
5 years, 8 months ago (2015-04-21 04:02:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5aba40cebe8c915c114f3d6ffd10a0c29f0f77d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698