Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp

Issue 1061503005: bindings: Use Maybe version of Call() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp
diff --git a/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp b/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp
index 90107ff46937b7ab5af7e72ddb19af68b8ee6f4c..052cbbede0f515e65081ed60755d8639adfe47e5 100644
--- a/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp
+++ b/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp
@@ -79,10 +79,9 @@ AtomicString V8CustomXPathNSResolver::lookupNamespaceURI(const String& prefix)
v8::Local<v8::Value> argv[argc] = { v8String(m_isolate, prefix) };
v8::Local<v8::Function> function = lookupNamespaceURIFunc.IsEmpty() ? v8::Local<v8::Function>::Cast(m_resolver) : lookupNamespaceURIFunc;
- v8::Local<v8::Value> retval = ScriptController::callFunction(callingExecutionContext(m_isolate), function, m_resolver, argc, argv, m_isolate);
-
+ v8::Local<v8::Value> retval;
// Eat exceptions from namespace resolver and return an empty string. This will most likely cause NamespaceError.
- if (tryCatch.HasCaught())
+ if (!ScriptController::callFunction(callingExecutionContext(m_isolate), function, m_resolver, argc, argv, m_isolate).ToLocal(&retval))
return nullAtom;
TOSTRING_DEFAULT(V8StringResource<TreatNullAsNullString>, returnString, retval, nullAtom);

Powered by Google App Engine
This is Rietveld 408576698