Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: Source/bindings/core/v8/Iterable.h

Issue 1061503005: bindings: Use Maybe version of Call() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/NPV8Object.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/Iterable.h
diff --git a/Source/bindings/core/v8/Iterable.h b/Source/bindings/core/v8/Iterable.h
index a24d10d3af89db7997c003cc33780f6ac841f780..43125b418db3b641bbe4eb1adcf768055dea30a5 100644
--- a/Source/bindings/core/v8/Iterable.h
+++ b/Source/bindings/core/v8/Iterable.h
@@ -65,9 +65,8 @@ public:
args[0] = toV8(value, creationContext, isolate);
args[1] = toV8(key, creationContext, isolate);
- V8ScriptRunner::callFunction(v8Callback, scriptState->executionContext(), v8ThisArg, 3, args, isolate);
-
- if (tryCatch.HasCaught()) {
+ v8::Local<v8::Value> result;
+ if (!V8ScriptRunner::callFunction(v8Callback, scriptState->executionContext(), v8ThisArg, 3, args, isolate).ToLocal(&result)) {
exceptionState.rethrowV8Exception(tryCatch.Exception());
return;
}
« no previous file with comments | « no previous file | Source/bindings/core/v8/NPV8Object.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698