bindings: Use Maybe version of Call()

Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 878 matching lines @@
 
 void WebLocalFrameImpl::requestExecuteScriptInIsolatedWorld(int worldID, const WebScriptSource* sourcesIn, unsigned numSources, int extensionGroup, bool userGesture, WebScriptExecutionCallback* callback)
 {
     ASSERT(frame());
     RELEASE_ASSERT(worldID > 0);
     RELEASE_ASSERT(worldID < EmbedderWorldIdLimit);
 
     SuspendableScriptExecutor::createAndRun(frame(), worldID, createSourcesVector(sourcesIn, numSources), extensionGroup, userGesture, callback);
 }
 
+// TODO(bashi): Consider returning MaybeLocal.
 #ifndef WEB_FRAME_USES_V8_LOCAL
 v8::Local<v8::Value> WebLocalFrameImpl::callFunctionEvenIfScriptDisabled(v8::Local<v8::Function> function, v8::Local<v8::Value> receiver, int argc, v8::Handle<v8::Value> argv[])
 #else
 v8::Local<v8::Value> WebLocalFrameImpl::callFunctionEvenIfScriptDisabled(v8::Local<v8::Function> function, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> argv[])
 #endif
 {
     ASSERT(frame());
-    // TODO(bashi): Change the signature of callFunctionEvenIfScriptDisabled()
-    // so that it takes v8::Local instead of v8::Handle.
-    return frame()->script().callFunction(function, receiver, argc, static_cast<v8::Local<v8::Value>*>(argv));
+    v8::Local<v8::Value> result;
+    if (frame()->script().callFunction(function, receiver, argc, static_cast<v8::Local<v8::Value>*>(argv)).ToLocal(&result))

[haraken, 2015/04/18 23:10:47]

Ditto.

[haraken, 2015/04/18 23:10:47]

Nit: I'd prefer using the following programming pattern for consistency.

if (!...)
  return ...;  // Fail
return ...;  // Success

[bashi, 2015/04/21 00:15:40]

Done.

[bashi, 2015/04/21 00:15:40]

Sorry, I couldn't find what you want to say here. Putting braces?

[haraken, 2015/04/21 04:38:54]

Ignore the comment :)

+        return result;
+    return v8::Local<v8::Value>();
 }
 
 v8::Local<v8::Context> WebLocalFrameImpl::mainWorldScriptContext() const
 {
     return toV8Context(frame(), DOMWrapperWorld::mainWorld());
 }
 
 void WebLocalFrameImpl::reload(bool ignoreCache)
 {
     ASSERT(frame());
@@ skipping 1195 matching lines @@
 {
     m_frameWidget = frameWidget;
 }
 
 WebFrameWidgetImpl* WebLocalFrameImpl::frameWidget() const
 {
     return m_frameWidget;
 }
 
 } // namespace blink