bindings: Use Maybe version of Call()

Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

 /*
  * Copyright (c) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 48 matching lines @@
         return true;
     }
 
     ASSERT(transactionHandle->IsObject());
 
     v8::Local<v8::Value> argv[] = {
         transactionHandle,
         errorHandle
     };
 
     v8::TryCatch exceptionCatcher;

[haraken, 2015/04/18 23:10:47]

Is this v8::TryCatch still needed?

[bashi, 2015/04/21 00:15:40]

I guess so. IIUC, it swallows an exception.

     exceptionCatcher.SetVerbose(true);
 
-    v8::Local<v8::Value> result = ScriptController::callFunction(executionContext(), m_callback.newLocal(isolate), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv, isolate);
-
+    v8::Local<v8::Value> result;
     // FIXME: This comment doesn't make much sense given what the code is actually doing.
     //
     // Step 6: If the error callback returns false, then move on to the next
     // statement, if any, or onto the next overall step otherwise. Otherwise,
     // the error callback did not return false, or there was no error callback.
     // Jump to the last step in the overall steps.
-    if (exceptionCatcher.HasCaught())
+    if (!ScriptController::callFunction(executionContext(), m_callback.newLocal(isolate), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv, isolate).ToLocal(&result))
         return true;
+
     bool value;
     V8_CALL(value, result, BooleanValue(isolate->GetCurrentContext()), return true);
     return value;
 }
 
 } // namespace blink