Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: Source/devtools/front_end/host/UserMetrics.js

Issue 1061503002: DevTools: use recordEnumeratedHistogram instead of recordActionTaken (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/host/UserMetrics.js
diff --git a/Source/devtools/front_end/host/UserMetrics.js b/Source/devtools/front_end/host/UserMetrics.js
index 62fa7c1152b45265945b973384e70f2319e0356a..ce1c44b422aa4d81741fe90738989283673d963c 100644
--- a/Source/devtools/front_end/host/UserMetrics.js
+++ b/Source/devtools/front_end/host/UserMetrics.js
@@ -83,9 +83,14 @@ WebInspector.UserMetrics.UserActionNames = {
};
WebInspector.UserMetrics.prototype = {
+ /**
+ * @param {string} panelName
+ */
panelShown: function(panelName)
{
- InspectorFrontendHost.recordPanelShown(WebInspector.UserMetrics._PanelCodes[panelName] || 0);
+ var code = WebInspector.UserMetrics._PanelCodes[panelName] || 0;
+ var size = Object.keys(WebInspector.UserMetrics._PanelCodes).length + 1;
+ InspectorFrontendHost.recordUMA("DevTools.PanelShown", code, size);
},
/**
@@ -93,7 +98,8 @@ WebInspector.UserMetrics.prototype = {
*/
actionTaken: function(action)
{
- InspectorFrontendHost.recordActionTaken(action);
+ var size = Object.keys(WebInspector.UserMetrics.Actions).length + 1;
+ InspectorFrontendHost.recordUMA("DevTools.ActionTaken", action, size);
}
}
WebInspector.userMetrics = new WebInspector.UserMetrics();

Powered by Google App Engine
This is Rietveld 408576698