Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js

Issue 1061503002: DevTools: use recordEnumeratedHistogram instead of recordActionTaken (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js
diff --git a/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js b/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js
index 370a872029bdb73760b93feff37aaf37a21b2a7d..27aa30289aa860733223b90dd098b68a68d6d99c 100644
--- a/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js
+++ b/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js
@@ -171,11 +171,22 @@ WebInspector.InspectorFrontendHostImpl.prototype = {
/**
* @override
+ * @param {string} actionName
+ * @param {number} actionCode
+ * @param {number} bucketSize
+ */
+ recordUMA: function(actionName, actionCode, bucketSize)
+ {
+ DevToolsAPI.sendMessageToEmbedder("recordUMA", [actionName, actionCode, bucketSize], null);
+ },
+
+ /**
+ * @override
dgozman 2015/04/03 14:23:48 Should not be override.
lushnikov 2015/04/03 14:41:24 Done.
* @param {number} actionCode
*/
recordActionTaken: function(actionCode)
dgozman 2015/04/03 14:23:48 Move to backwards-compat section.
lushnikov 2015/04/03 14:41:24 Done.
{
- DevToolsAPI.sendMessageToEmbedder("recordActionUMA", ["DevTools.ActionTaken", actionCode], null);
+ this.recordUMA("DevTools.ActionTaken", actionCode, 100);
},
/**
@@ -184,7 +195,7 @@ WebInspector.InspectorFrontendHostImpl.prototype = {
*/
recordPanelShown: function(panelCode)
{
- DevToolsAPI.sendMessageToEmbedder("recordActionUMA", ["DevTools.PanelShown", panelCode], null);
+ this.recordUMA("DevTools.PanelShown", panelCode, 20);
},
/**

Powered by Google App Engine
This is Rietveld 408576698