Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js

Issue 1061503002: DevTools: use recordEnumeratedHistogram instead of recordActionTaken (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @implements {InspectorFrontendHostAPI} 7 * @implements {InspectorFrontendHostAPI}
8 */ 8 */
9 WebInspector.InspectorFrontendHostImpl = function() 9 WebInspector.InspectorFrontendHostImpl = function()
10 { 10 {
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 * @override 164 * @override
165 * @param {string} message 165 * @param {string} message
166 */ 166 */
167 sendMessageToBackend: function(message) 167 sendMessageToBackend: function(message)
168 { 168 {
169 DevToolsHost.sendMessageToBackend(message); 169 DevToolsHost.sendMessageToBackend(message);
170 }, 170 },
171 171
172 /** 172 /**
173 * @override 173 * @override
174 * @param {string} actionName
175 * @param {number} actionCode
176 * @param {number} bucketSize
177 */
178 recordUMA: function(actionName, actionCode, bucketSize)
179 {
180 DevToolsAPI.sendMessageToEmbedder("recordUMA", [actionName, actionCode, bucketSize], null);
181 },
182
183 /**
184 * @override
dgozman 2015/04/03 14:23:48 Should not be override.
lushnikov 2015/04/03 14:41:24 Done.
174 * @param {number} actionCode 185 * @param {number} actionCode
175 */ 186 */
176 recordActionTaken: function(actionCode) 187 recordActionTaken: function(actionCode)
dgozman 2015/04/03 14:23:48 Move to backwards-compat section.
lushnikov 2015/04/03 14:41:24 Done.
177 { 188 {
178 DevToolsAPI.sendMessageToEmbedder("recordActionUMA", ["DevTools.ActionTa ken", actionCode], null); 189 this.recordUMA("DevTools.ActionTaken", actionCode, 100);
179 }, 190 },
180 191
181 /** 192 /**
182 * @override 193 * @override
183 * @param {number} panelCode 194 * @param {number} panelCode
184 */ 195 */
185 recordPanelShown: function(panelCode) 196 recordPanelShown: function(panelCode)
186 { 197 {
187 DevToolsAPI.sendMessageToEmbedder("recordActionUMA", ["DevTools.PanelSho wn", panelCode], null); 198 this.recordUMA("DevTools.PanelShown", panelCode, 20);
188 }, 199 },
189 200
190 /** 201 /**
191 * @override 202 * @override
192 */ 203 */
193 requestFileSystems: function() 204 requestFileSystems: function()
194 { 205 {
195 DevToolsAPI.sendMessageToEmbedder("requestFileSystems", [], null); 206 DevToolsAPI.sendMessageToEmbedder("requestFileSystems", [], null);
196 }, 207 },
197 208
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 }, 449 },
439 450
440 /** 451 /**
441 * Support for legacy front-ends (<M28). 452 * Support for legacy front-ends (<M28).
442 * @param {string} url 453 * @param {string} url
443 */ 454 */
444 close: function(url) 455 close: function(url)
445 { 456 {
446 } 457 }
447 } 458 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698