Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1061483002: Show UI when a folder is empty. (Closed)

Created:
5 years, 8 months ago by yawano
Modified:
5 years, 8 months ago
Reviewers:
yoshiki, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show UI when a folder is empty. BUG=464181 TEST=manually tested. Committed: https://crrev.com/e08da378d96d4fb5b2d73f866aa8b47e0a6a0218 Cr-Commit-Position: refs/heads/master@{#323741}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Change listen events. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/empty_folder.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/empty_folder.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/empty_folder_controller.js View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/ui/empty_folder.js View 1 chunk +30 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
yawano
PTAL. Thank you!
5 years, 8 months ago (2015-04-03 12:31:48 UTC) #2
fukino
lgtm. Thanks!
5 years, 8 months ago (2015-04-03 13:56:14 UTC) #3
yawano
PTAL private_api_strings.cc. Thank you!
5 years, 8 months ago (2015-04-03 13:58:36 UTC) #5
yoshiki
private_api_strings.cc lgtm
5 years, 8 months ago (2015-04-03 13:58:55 UTC) #6
yawano
On 2015/04/03 13:58:55, yoshiki wrote: > private_api_strings.cc lgtm Thank you!
5 years, 8 months ago (2015-04-03 13:59:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061483002/40001
5 years, 8 months ago (2015-04-03 13:59:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-03 14:24:47 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:37:40 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e08da378d96d4fb5b2d73f866aa8b47e0a6a0218
Cr-Commit-Position: refs/heads/master@{#323741}

Powered by Google App Engine
This is Rietveld 408576698