Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1061473004: Fix padding issues in First Run Account screen. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, jbroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix padding issues in First Run Account screen. Android support library has a bug b/20307607 that causes it to ignore padding set in XML on older (API 16) Android devices. BUG=469568 Committed: https://crrev.com/19c5c9b47829986c46eeaee7cb9aa08bf1908e57 Cr-Commit-Position: refs/heads/master@{#325574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/android/java/res/layout/fre_choose_account.xml View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunView.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-17 00:12:44 UTC) #2
newt (away)
lgtm
5 years, 8 months ago (2015-04-17 00:27:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061473004/1
5 years, 8 months ago (2015-04-17 00:30:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 00:58:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19c5c9b47829986c46eeaee7cb9aa08bf1908e57 Cr-Commit-Position: refs/heads/master@{#325574}
5 years, 8 months ago (2015-04-17 00:59:37 UTC) #7
jbroman
On 2015/04/17 00:59:37, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 8 months ago (2015-04-21 14:57:10 UTC) #8
aurimas (slooooooooow)
5 years, 8 months ago (2015-04-21 17:17:51 UTC) #9
Message was sent while issue was closed.
On 2015/04/21 at 14:57:10, jbroman wrote:
> On 2015/04/17 00:59:37, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/19c5c9b47829986c46eeaee7cb9aa08bf1908e57
> > Cr-Commit-Position: refs/heads/master@{#325574}
> 
> This introduces conflicting definitions of @dimen/fre_button_padding. Did you
mean to use a different name, or to change the value of the existing one?

I made a mistake. Just uploaded a fix https://codereview.chromium.org/1096113004

Powered by Google App Engine
This is Rietveld 408576698