Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1061473003: Always build dump_syms with the 'host' toolchain (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@arm_try_by_default
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always build dump_syms with the 'host' toolchain A recent change set linux_dump_symbols=1 on the trybots and was then reverted: https://codereview.chromium.org/1081103005 The causes the ARM/Linux builder to fail since it was attempting to run the target (ARM) dump_syms binary on x86. This change makes dump_syms a host binary so that it can run at build time. BUG=476781 TEST=linux_arm_compile trybot Committed: https://crrev.com/fe4acac6ff5547d7674e6681c9b556528520fdf7 Cr-Commit-Position: refs/heads/master@{#325661}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M breakpad/breakpad.gyp View 1 1 chunk +1 line, -5 lines 0 comments Download
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Sam Clegg
5 years, 8 months ago (2015-04-15 01:35:36 UTC) #2
Sam Clegg
On 2015/04/15 01:35:36, Sam Clegg wrote: I'm assuming dump_syms is only used during the build.. ...
5 years, 8 months ago (2015-04-15 01:47:40 UTC) #3
Lei Zhang
On 2015/04/15 01:47:40, Sam Clegg wrote: > On 2015/04/15 01:35:36, Sam Clegg wrote: > > ...
5 years, 8 months ago (2015-04-15 03:54:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061473003/40001
5 years, 8 months ago (2015-04-15 17:14:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56560)
5 years, 8 months ago (2015-04-15 17:23:40 UTC) #8
Sam Clegg
+jochen for build/OWNERS
5 years, 8 months ago (2015-04-15 17:26:36 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-17 09:23:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061473003/40001
5 years, 8 months ago (2015-04-17 16:13:40 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-17 17:23:58 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 17:25:00 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe4acac6ff5547d7674e6681c9b556528520fdf7
Cr-Commit-Position: refs/heads/master@{#325661}

Powered by Google App Engine
This is Rietveld 408576698