Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: shell/BUILD.gn

Issue 1061413002: Shell: Make a separate binary for child processes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Don't look at kChildProcess in desktop/main.cc. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/BUILD.gn
diff --git a/shell/BUILD.gn b/shell/BUILD.gn
index 4dcf57825bfc11fd94cc7fcfbbd0975e08a84bb5..b84cba01e6f86819ce17a8c2b3bcdcac662ae7bf 100644
--- a/shell/BUILD.gn
+++ b/shell/BUILD.gn
@@ -44,9 +44,7 @@ if (is_android) {
if (!mojo_use_prebuilt_mojo_shell) {
executable("mojo_shell") {
- sources = [
- "desktop/main.cc",
- ]
+ sources = []
deps = [
":init",
@@ -58,7 +56,11 @@ if (!mojo_use_prebuilt_mojo_shell) {
"//mojo/environment:chromium",
]
- if (is_android) {
+ data_deps = [ ":mojo_shell_child" ]
+
+ if (!is_android) {
+ sources += [ "desktop/main.cc" ]
+ } else {
sources += [
"android/library_loader.cc",
"android/main.cc",
@@ -77,6 +79,26 @@ if (!mojo_use_prebuilt_mojo_shell) {
]
}
}
+
+ executable("mojo_shell_child") {
+ sources = [
+ "child_main.cc",
+ ]
+
+ deps = [
+ # TODO(vtl): Reduce these dependencies (probably mostly in :lib).
+ ":child_controller_bindings",
+ ":init",
+ ":lib",
+ ":native_application_support",
+ "//base",
+ "//base/allocator",
+ "//build/config/sanitizers:deps",
+ "//mojo/common",
+ "//mojo/edk/system",
+ "//mojo/environment:chromium",
+ ]
+ }
} # !mojo_use_prebuilt_mojo_shell
source_set("init") {
@@ -108,8 +130,6 @@ source_set("in_process_native_runner") {
source_set("lib") {
sources = [
- "child_main.cc",
- "child_main.h",
"child_process_host.cc",
"child_process_host.h",
"command_line_util.cc",
@@ -292,6 +312,7 @@ if (is_android) {
clear_dir = true
dest = mojo_shell_assets_dir
sources = [
+ "$root_out_dir/exe.stripped/mojo_shell_child",
"$root_out_dir/lib.stripped/libbootstrap.so",
"$root_out_dir/network_service.mojo",
"$root_out_dir/obj/shell/bootstrap_java.dex.jar",
@@ -389,7 +410,8 @@ test("mojo_shell_tests") {
"//shell/application_manager",
]
- datadeps = [
+ data_deps = [
+ ":mojo_shell_child",
"//services/test_service:test_app",
"//services/test_service:test_request_tracker_app",
]

Powered by Google App Engine
This is Rietveld 408576698