Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: webkit/tools/layout_tests/layout_package/test_shell_thread.py

Issue 10614: Temporarily disable collecting and appending stderr output, to see if it make... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/layout_tests/layout_package/test_shell_thread.py
===================================================================
--- webkit/tools/layout_tests/layout_package/test_shell_thread.py (revision 5206)
+++ webkit/tools/layout_tests/layout_package/test_shell_thread.py (working copy)
@@ -80,18 +80,18 @@
# If we had any stderr output, append that. This is not ideal, but at least
# it'll catch errors.
- line = proc.stderr.readline()
- while line.rstrip() != "#EOF":
- # TODO(pamg): We suppress this stderr message temporarily so we can run
- # the tests deterministically until someone has a chance to fix the
- # underlying problem.
- # See http://code.google.com/p/chromium/issues/detail?id=4285
- if (line != '' and
- not line.endswith('alias ISO-8859-8-I maps to ISO-8859-8-I already, '
- 'but someone is trying to make it map to '
- 'ISO-8859-8')):
- outlines.append(line)
- line = proc.stderr.readline()
+# line = proc.stderr.readline()
+# while line.rstrip() != "#EOF":
+# # TODO(pamg): We suppress this stderr message temporarily so we can run
+# # the tests deterministically until someone has a chance to fix the
+# # underlying problem.
+# # See http://code.google.com/p/chromium/issues/detail?id=4285
+# if (line != '' and
+# not line.endswith('alias ISO-8859-8-I maps to ISO-8859-8-I already, '
+# 'but someone is trying to make it map to '
+# 'ISO-8859-8')):
+# outlines.append(line)
+# line = proc.stderr.readline()
# Check the output and save the results.
for test_type in test_types:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698