Issue 106133002: refactor emboldenGlyph

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106133002: refactor emboldenGlyph (Closed)

Created:
7 years ago by zheng.xu

Modified:
7 years ago

Reviewers:
bungeman-skia, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

refactor emboldenGlyph Previously emboldenOutline may happen in SkScalerContext_FreeType_Base and SkScalerContext_FreeType. While emboldenOutline will update the FreeType2 glyph slot. This causes the difficulty to work on some logic that depends on FreeType2 glyph slot. This patch makes SkScalerContext_FreeType to be the only one which embolden the glyphs. BUG=

Patch Set 1 #

Patch Set 2 : rebase and add bench cases for different font styles #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -30 lines)			Patch
M	bench/FontScalerBench.cpp	View	1	4 chunks	+47 lines, -9 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1	6 chunks	+4 lines, -12 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType_common.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType_common.cpp	View	1	3 chunks	+18 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

I think this is probably a good idea, but I'm hesitant to make changes around ...

7 years ago (2013-12-05 15:38:08 UTC) #3

Makes sense. Lets hold off until then.

Expand Messages | Collapse Messages